Skip to content

Add query frequency to mega PADD - #500

Open
yubiuser wants to merge 2 commits into
developmentfrom
dns_frequency
Open

Add query frequency to mega PADD#500
yubiuser wants to merge 2 commits into
developmentfrom
dns_frequency

Conversation

@yubiuser

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

Builds upon #494 and adds query frequency to mega PADD. Needs pi-hole/FTL#2806

2026-03-17_20-49

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser

Copy link
Copy Markdown
Member Author

I'm not sure if this is the best placement, but I thought client names usually are shorter than ad domains...

@yubiuser yubiuser mentioned this pull request Mar 21, 2026
@PromoFaux

Copy link
Copy Markdown
Member

Maybe in the System section above memory usage? Not sure...

@yubiuser

Copy link
Copy Markdown
Member Author

I don't think it fits there. It's not an information about the system but rather FTL

@DL6ER DL6ER left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to work as well here...

image

The new format reserves %-30s for ${top_client}, but mega truncates that value to 68 characters. Anything longer than 30 chars pushes the row right, potentially out of the entire PADD frame. I guess regular IPv6 addresses or similar hostnames will routinely hit this barrier.

I made an alternative suggestion in the code lines

Comment thread padd.sh Outdated
Comment thread padd.sh Outdated
@yubiuser

yubiuser commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Good catch. I like it.

I guess regular IPv6 addresses or similar hostnames will routinely hit this barrier.

This shows how much I use IPv6 and how short I keep my hostnames :-D

yubiuser and others added 2 commits August 5, 2026 15:56
Signed-off-by: yubiuser <github@yubiuser.dev>
Co-authored-by: Dominik <DL6ER@users.noreply.github.com>
Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser
yubiuser requested a review from DL6ER August 5, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants