Add query frequency to mega PADD - #500
Conversation
|
I'm not sure if this is the best placement, but I thought client names usually are shorter than ad domains... |
|
Maybe in the System section above memory usage? Not sure... |
|
I don't think it fits there. It's not an information about the system but rather FTL |
DL6ER
left a comment
There was a problem hiding this comment.
Doesn't seem to work as well here...
The new format reserves %-30s for ${top_client}, but mega truncates that value to 68 characters. Anything longer than 30 chars pushes the row right, potentially out of the entire PADD frame. I guess regular IPv6 addresses or similar hostnames will routinely hit this barrier.
I made an alternative suggestion in the code lines
|
Good catch. I like it.
This shows how much I use IPv6 and how short I keep my hostnames :-D |
Signed-off-by: yubiuser <github@yubiuser.dev>
Co-authored-by: Dominik <DL6ER@users.noreply.github.com> Signed-off-by: yubiuser <github@yubiuser.dev>
What does this PR aim to accomplish?:
Builds upon #494 and adds query frequency to mega PADD. Needs pi-hole/FTL#2806
By submitting this pull request, I confirm the following:
git rebase)