Add pihole-FTL bash completion - #1880
Merged
Merged
Conversation
yubiuser
marked this pull request as draft
August 6, 2025 12:07
Member
Author
|
Un-draft once the |
yubiuser
marked this pull request as ready for review
August 18, 2025 17:59
Member
Author
|
Core and FTL branch have been merged into development. |
Signed-off-by: yubiuser <github@yubiuser.dev>
Member
|
Are you sure this is needed? I think the Core PR will already install the files. |
Member
Author
|
If we want the feature on docker, we need this PR. On bare metall the completion file is installed with the installer, but on docker we don't run the installer and therefore need to copy the file manually. |
PromoFaux
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the FTL bash completion to the image. Depends on pi-hole/pi-hole#6376