Improve/check shutdown - #1899
Merged
Merged
Conversation
yubiuser
force-pushed
the
improve/check_shutdown
branch
from
September 27, 2025 13:10
abcee0a to
22f0411
Compare
PromoFaux
reviewed
Sep 28, 2025
PromoFaux
previously approved these changes
Sep 30, 2025
Member
|
Ah, needs a little rebase |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
…V systems Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
yubiuser
force-pushed
the
improve/check_shutdown
branch
from
September 30, 2025 18:24
2c02b87 to
1572fea
Compare
|
Conflicts have been resolved. |
Member
Author
|
Rebased and forced push. |
Signed-off-by: yubiuser <github@yubiuser.dev>
PromoFaux
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
test_pihole_ftl_clean_shutdownfunction. Instead of shutting down the container from within and delay shutdown togrepfor log lines, this PR shuts down the container from outside and usesdocker logto search for the relevant FTL log line.The second commit removes the
$PYTESTvariable: it was only used to delay the container shutdown during the tests and to skip creation of the default adlist. We can surely debate if we want to keep the variable anyways.