Skip to content

Drop the development tag, reduce dupliation in build yaml - #1906

Merged
PromoFaux merged 2 commits into
developmentfrom
dev-is-dev-is-nightly
Oct 8, 2025
Merged

Drop the development tag, reduce dupliation in build yaml#1906
PromoFaux merged 2 commits into
developmentfrom
dev-is-dev-is-nightly

Conversation

@PromoFaux

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

This PR does two things:

  • Drops the development tag. After thinking about it a lot, the development tag is next to pointless. And does not build when we end up in situations where the core/web/FTL code has changed in structure between their own master and dev branches. (See workaround: publish docker image by pushing on development branch #1905)
  • Reduces reuse of exact steps the build YAML by utilising YAML anchors, making it easier to maintain, and to reduce the possibility of error when updating two otherwise identical sections.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

…round, especially when there are file differences between master and dev on the other components. Instead, just update the `nightly` tag when the development branch has changes pushed to it.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux
PromoFaux requested a review from a team as a code owner October 6, 2025 21:00
Comment thread .github/workflows/build-and-publish.yml
Comment thread .github/workflows/build-and-publish.yml
Comment thread .github/workflows/build-and-publish.yml
@PromoFaux

Copy link
Copy Markdown
Member Author

We should now see the nightly get updated once I merge this...

@PromoFaux
PromoFaux merged commit d0bce70 into development Oct 8, 2025
15 of 16 checks passed
@PromoFaux
PromoFaux deleted the dev-is-dev-is-nightly branch October 8, 2025 18:48
@yubiuser

yubiuser commented Oct 8, 2025

Copy link
Copy Markdown
Member

Worked fine. Do we need to un-tag development once this has reached master?

@PromoFaux

Copy link
Copy Markdown
Member Author

It can stay there and just get older and older. I was toying with the idea of doing one last update to it to print something like the following on startup. But,.. probably not worth it.


!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! THIS TAG IS DEPRECATED - PLEASE USE NIGHTLY !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@yubiuser

yubiuser commented Oct 8, 2025

Copy link
Copy Markdown
Member

I think a note to the readme would be sufficient...

@rdwebdesign

Copy link
Copy Markdown
Member

I don't think we should update an image just to say the tag is deprecated and it won't be updated anymore.

I think a note to the readme would be sufficient

I agree we need a note on the README, but maybe we could retire the tag to make sure future users won't try to start containers using this tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants