Drop the development tag, reduce dupliation in build yaml - #1906
Merged
Conversation
…round, especially when there are file differences between master and dev on the other components. Instead, just update the `nightly` tag when the development branch has changes pushed to it. Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
rdwebdesign
approved these changes
Oct 6, 2025
yubiuser
requested changes
Oct 7, 2025
6 tasks
yubiuser
approved these changes
Oct 8, 2025
Member
Author
|
We should now see the nightly get updated once I merge this... |
Member
|
Worked fine. Do we need to un-tag |
Member
Author
|
It can stay there and just get older and older. I was toying with the idea of doing one last update to it to print something like the following on startup. But,.. probably not worth it. |
Member
|
I think a note to the readme would be sufficient... |
Member
|
I don't think we should update an image just to say the tag is deprecated and it won't be updated anymore.
I agree we need a note on the README, but maybe we could retire the tag to make sure future users won't try to start containers using this tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
This PR does two things:
developmenttag. After thinking about it a lot, thedevelopmenttag is next to pointless. And does not build when we end up in situations where the core/web/FTL code has changed in structure between their own master and dev branches. (See workaround: publish docker image by pushing on development branch #1905)By submitting this pull request, I confirm the following:
git rebase)