Set DNS listening mode to 'ALL' in docker-compose.yml example - #1946
Merged
Conversation
Signed-off-by: cornshakes <michael.hopfner@icloud.com>
yubiuser
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The code snippet in README.md contains this environment variable:
FTLCONF_dns_listeningMode: 'all'
This was changed to
FTLCONF_dns_listeningMode: 'ALL'
to reflect the current documentation.
Motivation and Context
When using lower case 'all', my pi-hole still only picked up local dns requests.
Changing it to 'ALL' made it accept dns requests from other clients on the network too.
How Has This Been Tested?
I made requests from different clients on the network. At first, they were not shown in the query log and not resolved by pi-hole. After the change, all the requests appeared in the query log and were resolved.
Types of changes
Checklist: