KM-11906: Fix crashes on automation settings - #186
Merged
kp-laura-sempere merged 3 commits intoSep 19, 2025
Conversation
- The issue was in the referenceSize of the Heard and Footer methds on the TrustedNeetworksViewController because these methods were directly calling the collection view's data source methods, which dequues views improperly.
- The root cause here is the same as the previous commit: directly calling the collection view's data source methods, which deques views improperly. Instead now we instantiate the cell directly from the XIB file.
kp-said-rehouni
approved these changes
Sep 19, 2025
kp-laura-sempere
deleted the
KM-11906_fix_crashes_on_automation_settings
branch
September 19, 2025 12:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a couple of crashes that were happening when performing various actions on the "Manage Automation" settings screen.
The root cause:
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Code formatting
Closing issues
Fixes #