Skip to content

KM-13284 Fix crash around PIAWelcomeViewController #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kp-diego-trevisan merged 1 commit into from
Dec 10, 2025
Merged

KM-13284 Fix crash around PIAWelcomeViewController #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions PIA VPN/UI/PIAWelcomeViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,13 @@ public class PIAWelcomeViewController: AutolayoutViewController, WelcomeCompleti
public override func viewDidLoad() {
super.viewDidLoad()

guard !preset.accountProvider.isLoggedIn else {
fatalError("You are already logged in, you might want to Client.database.truncate() to start clean")
if preset.accountProvider.isLoggedIn {
/// If the user is already logged in, this view controller should not have been presented.
/// This can happen due to a race condition.
/// We just dismiss it and it should trigger DashboardViewController's viewWillAppear,
/// which will evaluate isLoggedIn as true and take another path.
self.navigationController?.dismiss(animated: false)
return
}

buttonCancel.isHidden = true
Expand Down