Skip to content

KM-13381 Fix GHA's xcode-select #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kp-diego-trevisan merged 4 commits into from
Dec 15, 2025
Merged

KM-13381 Fix GHA's xcode-select #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f17c843
KM-13381 Replace setup-xcode step
kp-diego-trevisan Dec 15, 2025
958ada9
KM-13381 Add step for downloading the matching platform
kp-diego-trevisan Dec 15, 2025
be41363
KM-13381 Disable development_build workflow temporarely
kp-diego-trevisan Dec 15, 2025
8e6b88f
KM-13381 Run iOS tests only on iOS platform and stop compiling PIA VP…
kp-diego-trevisan Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/development_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: development_build
on:
push:
branches:
- master
# push:
# branches:
# - master

workflow_dispatch:
concurrency:
Expand All @@ -27,7 +27,12 @@ jobs:
- uses: actions/checkout@v4

- name: Select Xcode version
run: sudo xcode-select -s /Applications/Xcode_16.4.0.app
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: latest-stable

- name: Download iOS Platform
run: xcodebuild -downloadPlatform iOS

- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/ios_pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,12 @@ jobs:
- uses: actions/checkout@v4

- name: Select Xcode version
run: sudo xcode-select -s /Applications/Xcode_16.4.0.app
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: latest-stable

- name: Download iOS Platform
run: xcodebuild -downloadPlatform iOS

- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand All @@ -32,5 +37,5 @@ jobs:
run: gem install fastlane

- name: Run iOS unit tests
run: bundle exec fastlane tests
run: bundle exec fastlane iOStests

7 changes: 6 additions & 1 deletion .github/workflows/tvos_pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,12 @@ jobs:
- uses: actions/checkout@v4

- name: Select Xcode version
run: sudo xcode-select -s /Applications/Xcode_16.4.0.app
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: latest-stable

- name: Download tvOS Platform
run: xcodebuild -downloadPlatform tvOS

- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand Down
13 changes: 0 additions & 13 deletions PIA VPN.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,6 @@
remoteGlobalIDString = 0E67FC211E3F802D00EF9929;
remoteInfo = "PIA VPN Tunnel";
};
0EE220871F4F02D7002805AE /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 291C6374183EBC210039EC03 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 0EE2200B1F4EF307002805AE;
remoteInfo = "PIA VPN dev";
};
0EEE1BEC1E4F6EF400397DE2 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 291C6374183EBC210039EC03 /* Project object */;
Expand Down Expand Up @@ -779,7 +772,6 @@
);
dependencies = (
0EEE1BED1E4F6EF400397DE2 /* PBXTargetDependency */,
0EE220881F4F02D7002805AE /* PBXTargetDependency */,
);
name = "PIA VPNTests";
productName = "PIA VPNTests";
Expand Down Expand Up @@ -1467,11 +1459,6 @@
target = 0E67FC211E3F802D00EF9929 /* PIA VPN Tunnel */;
targetProxy = 0EE2200D1F4EF307002805AE /* PBXContainerItemProxy */;
};
0EE220881F4F02D7002805AE /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 0EE2200B1F4EF307002805AE /* PIA VPN dev */;
targetProxy = 0EE220871F4F02D7002805AE /* PBXContainerItemProxy */;
};
0EEE1BED1E4F6EF400397DE2 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 291C637B183EBC210039EC03 /* PIA VPN */;
Expand Down
28 changes: 0 additions & 28 deletions PIA VPN.xcodeproj/xcshareddata/xcschemes/PIA VPN.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,34 +48,6 @@
ReferencedContainer = "container:PIA VPN.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "NO"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "69B70AAF2ACBF51C0072A09D"
BuildableName = "PIA-VPN_E2E_Tests.xctest"
BlueprintName = "PIA-VPN_E2E_Tests"
ReferencedContainer = "container:PIA VPN.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "NO"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "E548E1F42C1238B5001E9874"
BuildableName = "PIA VPN-tvOS snapshot.xctest"
BlueprintName = "PIA VPN-tvOS snapshot"
ReferencedContainer = "container:PIA VPN.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
Expand Down
2 changes: 1 addition & 1 deletion fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ platform :ios do
anthropic_api_key = ENV['ANTHROPIC_API_KEY']
anthropic_model = "claude-sonnet-4-5"

lane :tests do
lane :iOStests do
run_tests(scheme: "PIA VPN")
end

Expand Down