Skip to content

KM-13371 Improve email validation and error messages - #217

Merged
kp-diego-trevisan merged 2 commits into
masterfrom
KM-13371-pia-email-error
Dec 19, 2025
Merged

KM-13371 Improve email validation and error messages#217
kp-diego-trevisan merged 2 commits into
masterfrom
KM-13371-pia-email-error

Conversation

@kp-diego-trevisan

@kp-diego-trevisan kp-diego-trevisan commented Dec 16, 2025

Copy link
Copy Markdown
Collaborator

Summary

  • Improve email validator logic and add check for empty emails
  • Add new localizable strings as error messages for each error case
  • Improve Validator unit tests
  • [Extra] Tweak GHA workflows to upload artifacts (had an issue happening only on GHA). I can split this into another PR if necessary.

This PR fixes/implements the following bugs/features

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

Test plan (required)

Code formatting

Closing issues

@kp-diego-trevisan
kp-diego-trevisan force-pushed the KM-13371-pia-email-error branch 2 times, most recently from 614d9aa to f8b6bbf Compare December 17, 2025 18:11

@kp-laura-sempere kp-laura-sempere left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, solid implementation ✅

@kp-diego-trevisan
kp-diego-trevisan merged commit 7d53c59 into master Dec 19, 2025
2 of 3 checks passed
@kp-diego-trevisan
kp-diego-trevisan deleted the KM-13371-pia-email-error branch December 19, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants