Skip to content

KM-13703 Fix persisting "Enable Debug Logging" and "Help Improve PIA" toggles #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kp-diego-trevisan merged 1 commit into from
Jan 9, 2026
Merged

KM-13703 Fix persisting "Enable Debug Logging" and "Help Improve PIA" toggles #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions PIA VPN/UI/Settings/HelpSettingsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,7 @@ class HelpSettingsViewController: PIABaseSettingsViewController {
}

@objc private func toggleDebugLogging(_ sender: UISwitch) {
let preferences = Client.preferences.editable()
preferences.debugLogging = sender.isOn
preferences.commit()
pendingPreferences.debugLogging = sender.isOn
reloadSettings()

if !sender.isOn {
Expand All @@ -91,18 +89,16 @@ class HelpSettingsViewController: PIABaseSettingsViewController {
}

@objc private func toggleShareServiceQualityData(_ sender: UISwitch) {
let preferences = Client.preferences.editable()
preferences.shareServiceQualityData = sender.isOn

pendingPreferences.shareServiceQualityData = sender.isOn

if sender.isOn {
preferences.versionWhenServiceQualityOpted = Macros.versionString()
pendingPreferences.versionWhenServiceQualityOpted = Macros.versionString()
ServiceQualityManager.shared.start()
} else {
preferences.versionWhenServiceQualityOpted = nil
pendingPreferences.versionWhenServiceQualityOpted = nil
ServiceQualityManager.shared.stop()
}

preferences.commit()

reloadSettings()
}

Expand Down Expand Up @@ -175,11 +171,11 @@ extension HelpSettingsViewController: UITableViewDelegate, UITableViewDataSource
case .debugLogging:
cell.accessoryView = switchDebugLogging
cell.selectionStyle = .none
switchDebugLogging.isOn = Client.preferences.debugLogging
switchDebugLogging.isOn = pendingPreferences.debugLogging
case .kpiShareStatistics:
cell.accessoryView = switchShareServiceQualityData
cell.selectionStyle = .none
switchShareServiceQualityData.isOn = Client.preferences.shareServiceQualityData
switchShareServiceQualityData.isOn = pendingPreferences.shareServiceQualityData
default:
break
}
Expand Down