Fix stringify of param names with control characters#445
Open
chatman-media wants to merge 1 commit into
Open
Conversation
Param names that aren't bare identifiers were quoted with JSON.stringify, which emits escapes like \n that parse() reads back as the literal letter n, so a name containing a control character didn't survive a parse->stringify->parse round trip. Quote with only the escapes the parser understands instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was round-tripping token data and noticed names with a control char don't come back the same:
parse(stringify(parse(':"a\nb"')))gives the nameanbinstead ofa\nb.The cause is that
stringifyNamefalls back toJSON.stringifywhen a name can't be emitted bare. JSON escaping uses sequences like\n/\t/\uXXXX, but the parser's quoted-name handling only understands\as "next char literal" — so it reads\nback as the lettern. The parser happily accepts these names in the first place (e.g.:"a<newline>b"), so stringify should be able to reproduce them.Switched to quoting that only escapes the two characters the parser treats specially inside quotes (
"and\). For names that just needed wrapping (digits, dashes, etc.) the output is unchanged, since JSON already produced the same thing there. Added a stringify case for a name with a newline.