Skip to content

test: stabilize flaky TestMainBackupLoop #69364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flaky-claw wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −15
Open

test: stabilize flaky TestMainBackupLoop #69364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions br/pkg/backup/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,9 @@ func TestMainBackupLoop(t *testing.T) {
res = append(res, ranges[len(ranges)-1].EndKey)
return res
}
storeIDForSplit := func(i int) uint64 {
return stores[i%len(stores)].GetId()
}

// Case #1: normal case
ranges := []rtree.KeyRange{
Expand All @@ -507,9 +510,9 @@ func TestMainBackupLoop(t *testing.T) {
mockBackupResponses := make(map[uint64][]*backup.ResponseAndStore)
splitKeys := splitRangesFn(ranges, 10)
for i := range len(splitKeys) - 1 {
randStoreID := uint64(rand.Int()%len(stores) + 1)
mockBackupResponses[randStoreID] = append(mockBackupResponses[randStoreID], &backup.ResponseAndStore{
StoreID: randStoreID,
storeID := storeIDForSplit(i)
mockBackupResponses[storeID] = append(mockBackupResponses[storeID], &backup.ResponseAndStore{
StoreID: storeID,
Resp: &backuppb.BackupResponse{
StartKey: splitKeys[i],
EndKey: splitKeys[i+1],
Expand Down Expand Up @@ -549,9 +552,9 @@ func TestMainBackupLoop(t *testing.T) {
splitKeys = splitRangesFn(ranges, 10)
// range is not complete
for i := range len(splitKeys) - 2 {
randStoreID := uint64(rand.Int()%len(stores) + 1)
mockBackupResponses[randStoreID] = append(mockBackupResponses[randStoreID], &backup.ResponseAndStore{
StoreID: randStoreID,
storeID := storeIDForSplit(i)
mockBackupResponses[storeID] = append(mockBackupResponses[storeID], &backup.ResponseAndStore{
StoreID: storeID,
Resp: &backuppb.BackupResponse{
StartKey: splitKeys[i],
EndKey: splitKeys[i+1],
Expand Down Expand Up @@ -593,9 +596,9 @@ func TestMainBackupLoop(t *testing.T) {
clear(mockBackupResponses)
splitKeys = splitRangesFn(ranges, 10)
for i := range len(splitKeys) - 1 {
randStoreID := uint64(rand.Int()%len(stores) + 1)
mockBackupResponses[randStoreID] = append(mockBackupResponses[randStoreID], &backup.ResponseAndStore{
StoreID: randStoreID,
storeID := storeIDForSplit(i)
mockBackupResponses[storeID] = append(mockBackupResponses[storeID], &backup.ResponseAndStore{
StoreID: storeID,
Resp: &backuppb.BackupResponse{
StartKey: splitKeys[i],
EndKey: splitKeys[i+1],
Expand Down Expand Up @@ -652,9 +655,9 @@ func TestMainBackupLoop(t *testing.T) {
clear(mockBackupResponses)
splitKeys = splitRangesFn(ranges, 10)
for i := range len(splitKeys) - 1 {
randStoreID := uint64(rand.Int()%len(stores) + 1)
mockBackupResponses[randStoreID] = append(mockBackupResponses[randStoreID], &backup.ResponseAndStore{
StoreID: randStoreID,
storeID := storeIDForSplit(i)
mockBackupResponses[storeID] = append(mockBackupResponses[storeID], &backup.ResponseAndStore{
StoreID: storeID,
Resp: &backuppb.BackupResponse{
StartKey: splitKeys[i],
EndKey: splitKeys[i+1],
Expand Down Expand Up @@ -705,9 +708,9 @@ func TestMainBackupLoop(t *testing.T) {
clear(mockBackupResponses)
splitKeys = splitRangesFn(ranges, 10)
for i := range len(splitKeys) - 1 {
randStoreID := uint64(rand.Int()%len(stores) + 1)
mockBackupResponses[randStoreID] = append(mockBackupResponses[randStoreID], &backup.ResponseAndStore{
StoreID: randStoreID,
storeID := storeIDForSplit(i)
mockBackupResponses[storeID] = append(mockBackupResponses[storeID], &backup.ResponseAndStore{
StoreID: storeID,
Resp: &backuppb.BackupResponse{
StartKey: splitKeys[i],
EndKey: splitKeys[i+1],
Expand Down
Loading