fix: pass middleware errors to pino-http - #71
Open
yowainwright wants to merge 1 commit into
Open
yowainwright wants to merge 1 commit into
yowainwright wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This revives the small fix from #20 against the current codebase.
When downstream Koa middleware throws:
koa-pino-loggercurrently logs the error immediately withctx.log.error({ err }), thenpino-httpalso logs the request on response completion, whichThis change stores the middleware error on
ctx.res.errand rethrows it, lettingpino-httpinclude the error in its normal response-completion log.request erroredandrequest completedbeing logged聽#19.Validation
npm testThank you!
~Jeff