Add join_corporation as a direct voice agent tool - #302
Open
atomantic wants to merge 1 commit into
Open
Conversation
Previously only create_corporation and leave_corporation were in VOICE_TOOLS, so when a pilot (especially one who skipped the tutorial) asked to join a corporation the voice agent had no matching tool and would hallucinate a non-existent UI panel instead of calling start_task to delegate to the task agent. - Register JOIN_CORPORATION in VOICE_TOOLS alongside create/leave - Add _handle_join_corporation with corp_name→corp_id resolution - Update voice_agent.md to list join/leave as direct tools and drop them from the start_task required list - Extend test_voice_agent.py with join_corporation coverage
Collaborator
|
@atomantic thanks for this PR, will review. I have inflight work to address and test joining corporations, primarily around task engines with larger fleets. I will branch from this PR and merge once we're fully confident. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pilot asks the voice agent to join a corporation, the agent has no
join_corporationtool registered (onlycreate_corporationandleave_corporationare inVOICE_TOOLS). Because the prompt'sstart_taskfallback isn't reliably triggered, the LLM hallucinates a non-existent "corporations panel" and refuses to act.This is especially visible for pilots who skipped the tutorial: they never pass through the scripted corp onboarding step, there is no corporation-join UI in the client for them to fall back to, and they have no in-game way to discover a list of corporations or join one. They get stuck — the voice agent is the only entry point, and it can't complete the action.
JOIN_CORPORATIONinVOICE_TOOLSalongsidecreate_corporationandleave_corporation_handle_join_corporationtoVoiceAgent, includingcorp_name→corp_idresolution vialist_corporations(mirrors the task-agent handler so a pilot can say "join Crimson Fleet" without a UUID)voice_agent.mdto listjoin_corporation/leave_corporationas direct tools and drop them from thestart_taskrequired listcorp_idandcorp_name-resolution join paths; updateEXPECTED_TOOLSset