Show corporation-member ships on the big map - #336
Closed
atomantic wants to merge 1 commit into
Closed
Conversation
Active corporation members piloting ships in visible sectors are now rendered on the big map as purple glow rings with pilot-name labels, making it easy to see where corp teammates are. - list_user_ships returns a new corp_member_ships field listing same-corp characters' currently-piloted, in-space ships - Client game store gains a corpMemberShips slice; GameContext wires the ships.list payload in - SectorMapFX adds renderCorpMemberGlows and renderCorpMemberLabels passes (purple glow + pilot-name badge, skipping the viewer's own current sector) - SectorMap and BigMapPanel thread corp_member_ships through with memo-safe key comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commanders had no visual indicator of where their corporation teammates were. This PR surfaces active corporation-member ships on the big map as purple glow rings with pilot-name badges, so it's obvious at a glance where teammates are operating.
Rebased off main (not #318), so it no longer carries the sector-name rename changes.
list_user_shipsreturns a newcorp_member_shipsfield listing same-corp characters' currently-piloted, in-space ships (ship_id, character, sector)corpMemberShipsslice;GameContextwires theships.listpayload inSectorMapFXaddsrenderCorpMemberGlowsandrenderCorpMemberLabelspasses — purple glow + pilot-name badge, skipping the viewer's own current sectorSectorMapandBigMapPanelthreadcorp_member_shipsthrough with memo-safe key comparison