chore(react): fixing tests. - #230
Merged
Merged
Conversation
filipi87
force-pushed
the
filipi/fix_client_react_tests
branch
from
June 18, 2026 17:16
5b56b2e to
4e8b904
Compare
filipi87
commented
Jun 18, 2026
Collaborator
Author
There was a problem hiding this comment.
These tests started to fail after my last commit when I added support for the RTVI 2.0.0 protocol.
I have fixed the tests, the messages should include text.
filipi87
commented
Jun 18, 2026
Collaborator
Author
There was a problem hiding this comment.
These tests started to fail after the changes in this PR:
filipi87
commented
Jun 18, 2026
Collaborator
Author
There was a problem hiding this comment.
New workflow to make sure the tests are always executed when we open a PR. 🙂
filipi87
commented
Jun 18, 2026
Collaborator
Author
There was a problem hiding this comment.
These tests started to fail after the changes in this PR:
filipi87
marked this pull request as ready for review
June 18, 2026 21:06
Regaddi
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(react): fixing tests.