Conversation
Every example that persists or uploads audio from AudioBufferProcessor hand-rolls the same wave.open block, including the pipecat init template. Give it a home next to the other PCM helpers.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Folded into #5285, which brings the whole Langfuse call-recording integration into core and includes this commit. Closing to avoid the same commit living in two PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
pcm_to_wav(pcm, sample_rate, num_channels=1)topipecat.audio.utils, wrapping raw s16le PCM in a WAV container.Why
Every example that persists or uploads audio from
AudioBufferProcessorhand-rolls the samewave.openblock, including thepipecat initserver template (src/pipecat/cli/templates/server/_macros/event_handlers.jinja2).audio/utils.pyalready holds the other PCM helpers (mix, interleave, ulaw/alaw), so this gives the WAV wrap a home next to them.Extracted from the Langfuse call-recording example (pipecat-ai/pipecat-examples#240), where it is one of three pieces of generic glue the example carries because core lacks them.
Test plan
tests/test_audio_utils.py: mono, stereo, and empty PCM round-trip throughwave.openwith the expected channels, width, rate, and frames.uv run pytest tests/test_audio_utils.py→ 3 passed.