Skip to content

Move log "Bot stopped" speaking from MediaSender to BaseOutputTransport #5663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NikolayShakin wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −4
Open

Move log "Bot stopped" speaking from MediaSender to BaseOutputTransport #5663

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
762f5f4
Move log "Bot stopped" speaking from MediaSender to BaseOutputTransport
Sep 8, 2026
e1aed0c
fix push_frame function signature to match the parent class, add defa…
Sep 8, 2026
e0df683
add filter by direction to avoid double logs on sibling frames
Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/pipecat/transports/base_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,16 @@ async def process_frame(self, frame: Frame, direction: FrameDirection):
else:
await self._handle_frame(frame)

async def push_frame(self, frame: Frame, direction: FrameDirection = FrameDirection.DOWNSTREAM):
"""Push a frame to the next processor in the pipeline."""
if isinstance(frame, BotStoppedSpeakingFrame) and direction == FrameDirection.DOWNSTREAM:
destination = frame.transport_destination
logger.debug(
f"Bot{f' [{destination}]' if destination else ''} stopped speaking"
)

await super().push_frame(frame, direction)

async def _handle_frame(self, frame: Frame):
"""Handle frames by routing them to appropriate media senders."""
if frame.transport_destination not in self._media_senders:
Expand Down Expand Up @@ -755,10 +765,6 @@ async def _bot_stopped_speaking(self):
# discarded rather than flushed, since it's no longer wanted.
self._audio_buffer = bytearray()

logger.debug(
f"Bot{f' [{self._destination}]' if self._destination else ''} stopped speaking"
)

downstream_frame = BotStoppedSpeakingFrame()
downstream_frame.transport_destination = self._destination
upstream_frame = BotStoppedSpeakingFrame()
Expand Down