fix(evals): restore speech when switching from text to audio sessions - #5722
Open
skulitom wants to merge 2 commits into
Open
fix(evals): restore speech when switching from text to audio sessions#5722skulitom wants to merge 2 commits into
skulitom wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eval transport now applies
skip_ttson every client connection beforeon_client_connected, so an audio scenario can produce speech after a text-mode scenario on the same bot process. Previously, only truthy flags were sent to the LLM service; theTruesetting persisted when the next client omitted the flag or sentskip_tts=false.This addresses the separate eval-harness problem reported in #5425 (comment). The original Flux/muting issue is outside this change.
Validation:
[True, True, True]instead of[True, False, True], and pass with the fix.pytest tests/test_evals_transport.py tests/test_websocket_server_transport.py tests/test_evals_session.py: 120 passed.ruff checkandruff format --checkpass; scoped Pyright reports no errors or warnings.AI disclosure: OpenAI Codex prepared the code, tests, and PR text and ran the validation above. The new regression tests use mocked transport I/O; no live LLM/TTS provider evaluation was run.