fix: include skipQueue tasks in queueSize getter (backport to v5)#1042
Open
algojogacor wants to merge 3 commits into
Open
fix: include skipQueue tasks in queueSize getter (backport to v5)#1042algojogacor wants to merge 3 commits into
algojogacor wants to merge 3 commits into
Conversation
Signed-off-by: Arya Rizky <arya.rizky@example.com>
metcoder95
reviewed
May 22, 2026
metcoder95
left a comment
Member
There was a problem hiding this comment.
can you add a test for it?
|
This issue has been marked as stale because it has been opened 45 days without activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an independent contribution and is not associated with any hackathon or competition.
Summary
Backport the queueSize fix from the
currentbranch tov5. The queueSize getter now accounts for tasks in skipQueue that were submitted with an AbortSignal.Root Cause
When tasks are submitted with an AbortSignal and cannot be scheduled immediately, they are placed in the
skipQueue(line 468 of src/index.ts) instead of thetaskQueue. However, thequeueSizegetter only countedtaskQueue.size, ignoring tasks waiting inskipQueue. This causedpool.queueSizeto report 0 even when tasks were queued.Fix
Added
+ pool.skipQueue.lengthto the queueSize getter calculation:This is a backport of the fix already present on the
currentbranch.Testing
skipQueueintegration already drains during_maybeDrain()— the getter now reflects its contents.Closes #1029