fix: include skipQueue in queueSize getter when using AbortSignal#1070
Open
lb1192176991-lab wants to merge 1 commit into
Open
fix: include skipQueue in queueSize getter when using AbortSignal#1070lb1192176991-lab wants to merge 1 commit into
lb1192176991-lab wants to merge 1 commit into
Conversation
Author
|
Hi maintainers! 👋 This PR fixes #1029 where The fix is a one-line change: Would appreciate a review when you have time. Happy to make any adjustments! Thanks! |
metcoder95
reviewed
Jun 12, 2026
metcoder95
left a comment
Member
There was a problem hiding this comment.
can you just alter the affected file, here it seems you are adding a totally new file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1029
When tasks are submitted with an AbortSignal, they may end up in
skipQueueinstead oftaskQueue. ThequeueSizegetter only accounted fortaskQueue.length, causingqueueSizeto report 0 even when tasks were waiting.This fix adds
this.skipQueue.lengthto thequeueSizecalculation.