refactor: small adjustments over WorkerInfo - #860
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the WorkerInfo class to improve its construction pattern and API design. The changes move from passing a pre-instantiated Worker to accepting worker configuration parameters, allowing the WorkerInfo class to manage Worker instantiation internally.
- Refactored WorkerInfo constructor to accept worker configuration instead of Worker instance
- Added new event handler methods to WorkerInfo for better encapsulation
- Reorganized worker initialization flow in ThreadPool to use the new WorkerInfo API
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/worker_pool/index.ts | Refactored WorkerInfo constructor and added new event handler methods for Worker lifecycle management |
| src/index.ts | Updated ThreadPool to use new WorkerInfo constructor pattern and reorganized worker initialization flow |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Carlos Fuentes <me@metcoder.dev>
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 48bf5fa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.