fix: fix sending orcid validate email on create author action during …#321
Open
zielaq wants to merge 1 commit into
Open
fix: fix sending orcid validate email on create author action during …#321zielaq wants to merge 1 commit into
zielaq wants to merge 1 commit into
Conversation
…submission wizzard
Member
|
Hi @pilasou, yes, I will review it this week and can include it in the next plugin release. Thanks! |
|
We're hitting this issue. Just curious if this PR will be merged soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending verification email when creating author is not working (its only work on edit action)
changed few things.
authorform:executeseems to not be used any moreAuthor::addhook calling same action as on editrequestOrcidAuthorizationanddeleteORCIDvalues from request (this is always available)sendAuthorMailremoved condition for saving author as during ADD hook is called before saving author by core application, and in ADD hook its called after. thats whyRepo::author()->dao->update($author);should be always called