Skip to content

fix: fix sending orcid validate email on create author action during …#321

Open
zielaq wants to merge 1 commit into
pkp:mainfrom
zielaq:send_validation_mail_on_create_author
Open

fix: fix sending orcid validate email on create author action during …#321
zielaq wants to merge 1 commit into
pkp:mainfrom
zielaq:send_validation_mail_on_create_author

Conversation

@zielaq

@zielaq zielaq commented Aug 27, 2024

Copy link
Copy Markdown

Sending verification email when creating author is not working (its only work on edit action)
changed few things.

  • authorform:execute seems to not be used any more
  • on Author::add hook calling same action as on edit
  • getting requestOrcidAuthorization and deleteORCID values from request (this is always available)
  • in sendAuthorMail removed condition for saving author as during ADD hook is called before saving author by core application, and in ADD hook its called after. thats why Repo::author()->dao->update($author); should be always called

@asmecher

Copy link
Copy Markdown
Member

Thanks, @zielaq! @ewhanson, for your consideration...

@pilasou

pilasou commented Jan 13, 2025

Copy link
Copy Markdown

Hi @alex, thanks @zielaq ! will this PR be merged soon? Will it be added to the next OJS ORCID plugin release?

@ewhanson ewhanson self-requested a review January 13, 2025 20:41
@ewhanson

Copy link
Copy Markdown

Hi @pilasou, yes, I will review it this week and can include it in the next plugin release. Thanks!

@dkinzer

dkinzer commented Apr 29, 2026

Copy link
Copy Markdown

We're hitting this issue. Just curious if this PR will be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants