Kind 20 support for picture notes posted from Olas#1753
Open
Kind 20 support for picture notes posted from Olas#1753
Conversation
rabble
requested review from
bryanmontz,
joshuatbrown,
martindsq,
mplorentz and
pelumy
as code owners
- Remove duplicate videoPost method in JSONEvent+Kinds.swift - Simplify constructors using tuple assignment - Add better error handling and loading states to VideoNoteCard - Fix conditional bug in NoteCard.swift - Implement helper methods for tag parsing - Improve RepliesLabel error handling with fallbacks - Add throttling to avoid excessive avatar computations - Add type safety improvements with tagArray computed property 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Added EventTagHelpersTests.swift to test tag parsing helpers - Added tests for Picture Post and Video Post JSONEvent methods - Created comprehensive documentation in doc/nip68_71_implementation.md - Updated KIND_20_IMPROVEMENTS.md with completed checklist 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Enhanced URL parsing to handle various format of video URLs - Added MIME type detection and format checking for better video identification - Improved video player with robust error handling and status reporting - Added playback controls and loading states for better UX - Added fallback options for various kinds of media tags - Separated dedicated VideoPlayerView component for better maintainability 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added Logger import to fix compile error 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix implicit return warnings in tag helper methods - Fix brace formatting in NoteCard conditional logic - Add comprehensive tests for MIME type detection and video tag identification - Improve code formatting and readability
Change 'error as NSError' to 'error as? NSError' to correctly handle the optional type conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues covered
Add support for picture notes in feeds
Description
This PR adds support for displaying picture notes (posts containing images) in the feed with an optimized layout. Key changes include:
How to test
Screenshots/Video
Updated UI
Old version not displaying kind 20 events.
