Fix viewer auto-load, .jsonl support, and filter out coz.h experiments#268
Merged
emeryberger merged 1 commit intomasterfrom Feb 16, 2026
Merged
Fix viewer auto-load, .jsonl support, and filter out coz.h experiments#268emeryberger merged 1 commit intomasterfrom
emeryberger merged 1 commit intomasterfrom
Conversation
Three related fixes for the coz plot viewer: 1. Profile emitter: skip coz.h lines when selecting experiments, so instrumentation overhead is never profiled or emitted. 2. Server-side filter: the old line-by-line '/coz.h:' filter removed experiment lines but left orphaned throughput_point lines, causing the JS Profile constructor to crash (null experiment reference). Replaced with a paired filter that skips both the experiment and its subsequent data points. 3. Viewer UI: accept .jsonl files in file inputs, drag-and-drop, and validation. Call checkAutoLoad() directly instead of waiting for DOMContentLoaded (scripts are at bottom of body, DOM is ready). Add client-side coz.h filtering as a safety net for manual uploads. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coz.hlines when selecting experiments so instrumentation overhead is never profiled or emitted (handles both/and\path separators for future Windows portability)/coz.h:filter that removed experiment lines but left orphanedthroughput_pointlines (crashing the JS Profile constructor with a null reference). New filter properly skips both experiment and subsequent data point lines as a pair.jsonlfiles in file inputs, drag-and-drop, and validation. CallcheckAutoLoad()directly instead of waiting forDOMContentLoaded. Add client-sidecoz.hfiltering as safety net for manual uploadsTest plan
makesucceeds)coz.hlines in output, correct ~50% speedup on line 18coz plot --textshows clean results?load=auto-load mechanism.jsonldrag-and-drop upload in browser.jsonlfile picker upload in browser🤖 Generated with Claude Code