Adopt @playcanvas/eslint-config v3 (/typescript)#43
Draft
kpal81xd wants to merge 1 commit into
Draft
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the v3 rollout — playcanvas/eslint-config#48 (new adoption — this repo did not previously use
@playcanvas/eslint-config).What changed
/typescripttier as the repo's root ESLint config. This repo had no prior root ESLint setup (noeslint.config.*, nolintscript, no eslint devDeps), so this introduces linting for the CLI's own source undersrc/(andindex.js,package.json).eslint.config.mjsthat composes@playcanvas/eslint-config/typescriptand ignorestemplates/anddist(template projects ship their own ESLint setup; only this repo's own source is linted).lintscript (eslint .)..npmrc(registry=https://registry.npmjs.org/) to keep the lockfile on the public registry.@playcanvas/eslint-config@3.0.0-beta.6andeslint@^9.39.0(peer of the shared config; not previously present); removed redundant eslint plugin/parser devDeps now bundled by the shared config: none (the repo had no prior ESLint dependencies to remove).Lint status
Draft — config loads cleanly; 33 errors / 0 warnings remain (new strict-mode coverage this repo wasn't linted under before). Not fixed here per the rollout policy (keep the shared config strict, triage separately).