refactor(gsplat): extract GSplatWorld from GSplatManager#8916
Merged
Conversation
Split GSplatManager's two responsibilities apart. The new GSplatWorld owns the work buffer, versioned world states, allocation, octree/LOD evaluation, streaming, budget enforcement, and the work-buffer bake. GSplatManager keeps a single renderer, the sorters, interval compaction, the projector, and per-camera cull/sort. The dependency is strictly one-way (manager -> world): the manager reads world data through getters and drives mutation via explicit methods (update/bake/markSorted/ onSorted/syncFormat/invalidate/reconcile), with results written into caller-owned persistent objects to avoid per-frame allocation. Behaviour-preserving; 1:1 (each manager owns one world, no sharing yet). Also replace the LOD-cadence 'lose a tick' behaviour with a latched request, so a periodic LOD update deferred by sorter back-pressure fires on the next available frame instead of waiting another full cadence interval. This is step one toward letting the hybrid GPU-sort renderer share splat data across multiple renderers (e.g. a shadow renderer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits
GSplatManager's two unrelated responsibilities apart, as the first step toward letting the hybrid GPU-sort renderer share splat data across multiple renderers (e.g. a future shadow renderer).Changes:
GSplatWorld(src/scene/gsplat-unified/gsplat-world.js) owns the work buffer, versioned world states, allocation, octree/LOD evaluation, streaming, budget enforcement, and the work-buffer bake.GSplatManagerkeeps the single renderer, the sorters, interval compaction, the projector, and per-camera cull/sort — and delegates the world responsibilities to itsGSplatWorld.update/bake/markSorted/onSorted/syncFormat/invalidate/reconcile). Results are written into caller-owned persistent objects to avoid per-frame allocation.GSplatIntervalCompaction.invalidateUpload()added to replace a direct private-field poke from the manager.Performance:
All
GSplatWorld/GSplatManagermembers are internal (@ignore); no public API changes.