refactor: Remove unused JSDoc @import lines from sound and rigid-body components#8920
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unused JSDoc @import type-only declarations for Entity from two framework component modules, aligning with the cleanup approach used in #8677 and keeping type-only imports limited to symbols referenced in actual JSDoc type annotations.
Changes:
- Removed unused JSDoc
@import { Entity }fromSoundComponentdocs header. - Removed unused JSDoc
@import { Entity }block fromRigidBodyComponent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/framework/components/sound/component.js | Drops unused @import { Entity } while retaining the needed SoundInstance type import. |
| src/framework/components/rigid-body/component.js | Removes an unused Entity-only JSDoc import block (Entity remains referenced only via {@link ...} in docs). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
approved these changes
Jun 18, 2026
Contributor
|
Well spotted, @mmjinglin163! How did you find these? Intellisense didn't highlight them. |
Contributor
Author
|
I discovered through cursor analysis in the engineering project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes unused JSDoc @import type-only lines that are not referenced in the file:
SoundComponent — Entity
RigidBodyComponent — Entity
These imports were only referenced via @link in documentation and not in type annotations (@type, @param, @returns). No runtime behavior changes.
Following the pattern established in #8677.