Skip to content

Type and lint fixes#515

Merged
kpal81xd merged 7 commits into
mainfrom
typefix
Jun 20, 2025
Merged

Type and lint fixes#515
kpal81xd merged 7 commits into
mainfrom
typefix

Conversation

@kpal81xd

@kpal81xd kpal81xd commented Jun 19, 2025

Copy link
Copy Markdown
Contributor
  • Fixed linting for *.mjs files
  • Pinned @rollup/plugin-typescript to 12.1.2 (Fixes external types referenced in include)

@kpal81xd kpal81xd self-assigned this Jun 19, 2025
@kpal81xd kpal81xd requested a review from slimbuck June 19, 2025 11:16
@johnbanq

Copy link
Copy Markdown
Contributor

Hi! I have two questions regarding this PR:

  • In commit d7c5252, what is the reasoning for disabling rule 'import/no-unresolved' for all mjs files?
  • commit 3445948 disabled type checking during rollup build and 45d314f put that into CI instead. Is this done to reduce build time, or to fix the problem caused by PR Update deps #513 ?

Thanks in advance!

@kpal81xd

kpal81xd commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

Hi! I have two questions regarding this PR:

  • In commit d7c5252, what is the reasoning for disabling rule 'import/no-unresolved' for all mjs files?
  • commit 3445948 disabled type checking during rollup build and 45d314f put that into CI instead. Is this done to reduce build time, or to fix the problem caused by PR Update deps #513 ?

Thanks in advance!

So the import/no-resolved was mainly for the eslint.config.mjssince the parsers import typing is invalid. It doesnt have to be scoped that wide I can just disable those particular import lines in the file

Technically its both - there was an import resolution issue with including external types for svg imports so disabled the typechecking in the rollup build and switched to the CI (related rollup/plugins#1878) . Additionally this does speed up the build itself since type checking is done upfront

Comment thread tsconfig.json
Comment thread tsconfig.json Outdated
@johnbanq

johnbanq commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

Hi! I have two questions regarding this PR:

  • In commit d7c5252, what is the reasoning for disabling rule 'import/no-unresolved' for all mjs files?
  • commit 3445948 disabled type checking during rollup build and 45d314f put that into CI instead. Is this done to reduce build time, or to fix the problem caused by PR Update deps #513 ?

Thanks in advance!

So the import/no-resolved was mainly for the eslint.config.mjssince the parsers import typing is invalid. It doesnt have to be scoped that wide I can just disable those particular import lines in the file

Technically its both - there was an import resolution issue with including external types for svg imports so disabled the typechecking in the rollup build and switched to the CI (related rollup/plugins#1878) . Additionally this does speed up the build itself since type checking is done upfront

Thanks for your detailed answer! I actually managed to get the type checking problem to go away this morning as well. I have left what I discovered as comments, hope this is helpful!

Comment thread rollup.config.mjs Outdated
@kpal81xd kpal81xd merged commit 6431417 into main Jun 20, 2025
2 checks passed
@kpal81xd kpal81xd deleted the typefix branch June 20, 2025 13:36
JonathanAmdahl pushed a commit to braintrance-net/supersplat that referenced this pull request Apr 16, 2026
* Fixed lint in rollup config mjs file

* Split out type checking into separate script and build without type checking

* Add type checking job to CI workflow

* Remove empty VSCode settings file

* Add .vscode to .gitignore

* Pinned rollup typescript version to 12.1.2 and reverted typecheck to rollup

* Added back debug exclude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants