Conversation
|
Hi! I have two questions regarding this PR:
Thanks in advance! |
So the Technically its both - there was an import resolution issue with including external types for svg imports so disabled the typechecking in the rollup build and switched to the CI (related rollup/plugins#1878) . Additionally this does speed up the build itself since type checking is done upfront |
Thanks for your detailed answer! I actually managed to get the type checking problem to go away this morning as well. I have left what I discovered as comments, hope this is helpful! |
* Fixed lint in rollup config mjs file * Split out type checking into separate script and build without type checking * Add type checking job to CI workflow * Remove empty VSCode settings file * Add .vscode to .gitignore * Pinned rollup typescript version to 12.1.2 and reverted typecheck to rollup * Added back debug exclude
*.mjsfiles@rollup/plugin-typescriptto 12.1.2 (Fixes external types referenced in include)