Open
Conversation
dktapps
requested changes
Nov 30, 2025
Member
dktapps
left a comment
There was a problem hiding this comment.
This looks mostly OK, good work
However, some comments below
kostamax27
reviewed
Nov 30, 2025
dktapps
reviewed
Dec 3, 2025
Member
|
Please make the build pass. I also don't like the idea of adding functions inside which the compostability gets hardcoded. I've been trying to move away from that generally, since it's inflexible and requires tons of useless classes. It'd be better if we had some way to inject this information into item constructors where it's appropriate. For Blocks, it could go in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Composter
Related issues & PRs
Related to #4742
Changes
API changes
Block
ComposterFernLargeFernNetherWartPitcherPlantShroomLightTorchFlowerWarpedWartBlockClass:getCompostabilityChance()isCompostable()BaseBigDripleafBaseCakeCactusCactusFlowerDoubleTallGrassDriedKelpFlowerGlowLichenGrassHangingRootsHayBaleLeavesMangroveRootsMelonMushroomStemNetherRootsNetherVinesNetherWartPlantPinkPetalsPumpkinRedMushroomRedMushroomBlockSaplingSeaPickleSmallDripleafSporeBlossomStemSugarCaneTallGrassVineWaterLilyWitherRoseEvent
ComposterEmptyEventComposterFillEventComposterReadyEventItem
WheatItem&ItemBlockClasses:getCompostabilityChance()isCompostable()AppleBakedPotatoBeetrootBeetrootSeedsBreadCarrotCocoaBeansCookieDriedKelpGlowBerriesMelonMelonSeedsPitcherPodPotatoPumpkinPiePumpkinSeedsSweetBerriesTorchflowerSeedsWheatSeedsWorld
CropGrowthEmitterParticleComposterEmptySoundComposterFillSoundComposterFillSuccessSoundComposterReadySoundFollow-up
Once more items/blocks are added could check if they are compostable
Tests
Composter functionality Video