fix: uniforms have stable refs for ShaderMaterial#3715
Open
fix: uniforms have stable refs for ShaderMaterial#3715
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6182ec3:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a uniform is recreated due to a rerender or simply an HMR and the uniform is passed in as a prop, then it overwrites the uniforms object.
This is catastrophic for Three which assumes this object never changes in its program caching. This leads people to do silly things like put
Math.random()in the key prop forcing the material itself to regenerate every rerender.This change makes the uniforms objects on
ShaderMaterialand its derivatives have a stable reference. Anything passed intouniformswill instead copy into it. This is the same as behavior for math structures that have copy such as position, rotation, quaternion, etc.The user would then get the uniforms ref from the material ref itself.