Skip to content

fix: handle empty or invalid commits in withFiles and onlyPackageCommits functions #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
freddie-manatal wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: handle empty or invalid commits in withFiles and onlyPackageCommits functions #176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b81727f
fix: handle empty or invalid commits in withFiles and onlyPackageComm…
freddie-manatal Jul 18, 2025
ab84792
fix: return structured empty response for null or invalid commits in …
freddie-manatal Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/only-package-commits.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ const getPackagePath = async () => {
};

const withFiles = async commits => {
// Handle case where commits is null, undefined, or not an array
if (!commits || !Array.isArray(commits) || commits.length === 0) {
return {
// Return an empty array of commits with no files
commits: [],
files: []
}
}

const limit = pLimit(Number(process.env.SRM_MAX_THREADS) || 500);
return Promise.all(
commits.map(commit =>
Expand All @@ -33,6 +42,15 @@ const withFiles = async commits => {
};

const onlyPackageCommits = async commits => {
// Handle case where commits is null, undefined, or not an array
if (!commits || !Array.isArray(commits) || commits.length === 0) {
return {
// Return an empty array of commits with no files
commits: [],
files: []
};
}

const packagePath = await getPackagePath();
debug('Filter commits by package path: "%s"', packagePath);
const commitsWithFiles = await withFiles(commits);
Expand Down