Fix Approve method to call ApproveAsync, not CheckinAsync#1712
Merged
gautamdsheth merged 1 commit intopnp:devfrom Dec 13, 2025
Merged
Fix Approve method to call ApproveAsync, not CheckinAsync#1712gautamdsheth merged 1 commit intopnp:devfrom
gautamdsheth merged 1 commit intopnp:devfrom
Conversation
The Approve method now correctly invokes ApproveAsync instead of CheckinAsync, ensuring the synchronous and asynchronous methods are properly aligned.
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the Approve method where it was incorrectly calling CheckinAsync instead of ApproveAsync. This misalignment caused the synchronous Approve() method to perform a checkin operation instead of approving the file, leading to incorrect behavior.
Key Changes:
- Fixed the
Approvemethod to call the correct async counterpart (ApproveAsyncinstead ofCheckinAsync)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Approve method now correctly invokes ApproveAsync instead of CheckinAsync, ensuring the synchronous and asynchronous methods are properly aligned.