docs: fix pull --policy value from newer to ifnewer - #6994
Conversation
The buildah pull man page documented --policy=newer, but the CLI accepts only ifnewer via define.PolicyMap. Align the docs with the actual flag values (missing, always, ifnewer, or never). Fixes podman-container-tools#6992 Signed-off-by: Dean Chen <862469039@qq.com>
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
The Packit COPR failures look infrastructure-side rather than related to this docs-only change: SRPM built successfully; the chroot never got past waiting for Change is only /packit build |
Signed-off-by: Dean Chen <862469039@qq.com>
Docs-only change; previous failures were COPR base repo timeouts. Signed-off-by: Dean Chen <862469039@qq.com>
|
/packit build |
|
We do want to accept aliases for some of these, though. Pitching #7000 to do that. |
|
@nalind Makes sense — accepting aliases on the CLI side is the better fix. Glad #7000 covers that. This PR only corrects the man page so it documents the canonical |
|
On that note, can we describe the two as being equivalent? IIRC the set of values we document here is meant to be in line with |
|
Just a note: it's a little frustrating to spend time using and understanding the code, opening an issue, and working on a solution, only to later see someone use AI to duplicate the pull request. Ofc, this is just a typo, but it is happening even to bigger PRs. My friends who are more involved in open source complain about this all the time. |
Align the pull policy description with podman-pull(1): the policy podman documents as "newer" is the same behavior as buildah's ifnewer. Signed-off-by: Dean Chen <862469039@qq.com>
|
@nalind Good call — updated the man page to state that buildah's Agree on accepting aliases in the CLI map; happy to leave that to #7000 rather than expanding |
|
Hold up, why did this start as an exact duplicate of #6993? |
|
@nalind yeah, bad timing on my side. #6993 already had the ifnewer fix when i opened this — i should've checked and pointed at that instead of stacking another PR on the same typo. closing this in favor of #6993. sorry for the noise @leonardomoreira00. |
Summary
The
buildah pullman page documented--policy=newer, but the CLI only acceptsifnewerviadefine.PolicyMap(seecmd/buildah/pull.goanddefine/pull.go). Using--policy newerfails with:Update
docs/buildah-pull.1.mdso the documented values match the CLI:always,missing,never, andifnewer.Note:
buildah from/buildah build--pulldocs that mentionnewerare intentionally left unchanged; those commands parse bothnewerandifnewerviaparse.PullPolicyFromOptions.Fixes #6992
Test plan
--policy string missing, always, ifnewer, or never.define.PolicyMapkeys are onlymissing,always,never,ifnewerifnewerconsistently in the flag synopsis and bullet list