fix: unlock audio context so UI sounds play on deploy - #25
Merged
Conversation
mouseenter is not a valid user-activation gesture, so a hover before the first click left the AudioContext suspended while the engine latched a "started" flag and never retried — silencing all sounds. Re-check the real context state on every call and add document-level pointerdown/touchstart/ keydown listeners that unlock audio on the first genuine gesture anywhere.
ShreyashSri
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
UI interaction sounds (from the Tone.js
useRetroSoundengine merged in #22) do not play on the live deployment.Root cause
mouseenter(hover) is not a valid user-activation gesture for resuming a Web Audio context. The engine calledTone.start()on the first interaction and immediately latched astarted = trueflag. When that first interaction was a hover (almost always, before any click), the context stayed suspended but the flag was set — so every subsequent click short-circuited and audio never played.Fix
Tone.getContext().stateon every call instead of latching astartedflag; keep retryingTone.start()until the context is actuallyrunning.pointerdown/touchstart/keydownlisteners so the first genuine gesture anywhere on the page unlocks audio (and detach them once unlocked).One file changed:
components/landing/hooks/useRetroSound.ts.Test
tsc --noEmitpasses.started/bootinglatch and now resumes on real gestures.🤖 Generated with Claude Code