Support eager navigation destination resolution#241
Draft
stephencelis wants to merge 2 commits intomainfrom
Draft
Support eager navigation destination resolution#241stephencelis wants to merge 2 commits intomainfrom
stephencelis wants to merge 2 commits intomainfrom
Conversation
Currently we steer folks to using `viewDidLoad` for all observation, but this laziness can lead to issues with deep-linking in type-erased navigation stacks, where a destination may declare a sub-destination in its `viewDidLoad`, causing the first drill-down to occur lazily over multiple animated steps instead of a single one. This behavior can be seen in the type-erased navigation case study in the repository. This PR is a proof of concept to show that the library can populate a "current navigation stack" in the UI transaction so that a destination's initializer can declare its dependent destinations, fixing the case study behavior.
stephencelis
commented
Oct 16, 2024
Comment on lines
+341
to
+343
| withUITransaction(\.stackController, stackController) { | ||
| stackController.path.append(.lazy(.element(value))) | ||
| } |
Member
Author
There was a problem hiding this comment.
This fixes things just for the case study, but because deep linking can happen directly from state we would need to explore a more universal solution to ship this.
Contributor
|
Will the modern concurrency updates pave the path for making PRs like this possible? I’m curious whether this library will get more attention in the near future because of what you guys have learned in your TCA 2.0 development work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we steer folks to using
viewDidLoadfor all observation, but this laziness can lead to issues with deep-linking in type-erased navigation stacks, where a destination may declare a sub-destination in itsviewDidLoad, causing the first drill-down to occur lazily over multiple animated steps instead of a single one. This behavior can be seen in the type-erased navigation case study in the repository.This PR is a proof of concept to show that the library can populate a "current navigation stack" in the UI transaction so that a destination's initializer can declare its dependent destinations, fixing the case study behavior.
An idea brought up by @iampatbrown.