Skip to content

feat: Sharing trait#331

Merged
stephencelis merged 10 commits intopointfreeco:mainfrom
maximkrouk:navigation-sharing
Apr 1, 2026
Merged

feat: Sharing trait#331
stephencelis merged 10 commits intopointfreeco:mainfrom
maximkrouk:navigation-sharing

Conversation

@maximkrouk
Copy link
Copy Markdown
Contributor

@maximkrouk maximkrouk commented Feb 26, 2026

Introduces SwiftNavigationSharing trait for the package that provides UIBinding initializer from Shared values

Warning

Requires new swift-sharing release 2.7.5 that includes these changes pointfreeco/swift-sharing#205

@maximkrouk
Copy link
Copy Markdown
Contributor Author

Note

CI failed as expected
Reason: swift-sharing 2.7.5 is not yet released

@stephencelis
Copy link
Copy Markdown
Member

@maximkrouk We just cut Sharing 2.8.0. Wanna get things cleaned up and green?

@maximkrouk
Copy link
Copy Markdown
Contributor Author

@maximkrouk We just cut Sharing 2.8.0. Wanna get things cleaned up and green?

What do you think about using "Sharing" trait name instead of "SwiftNavigationSharing"?

@stephencelis
Copy link
Copy Markdown
Member

@maximkrouk Down for that. I think early examples in Apple's packages concatenated/connected two packages in the naming, but it seems to have moved a different direction.

@maximkrouk maximkrouk changed the title feat: SwiftNavigationSharing trait feat: Sharing trait Mar 31, 2026
@stephencelis
Copy link
Copy Markdown
Member

@maximkrouk Lemme know if you think things are ready! I like the look of things so far but if you're still working we can wait to review further 😄

@maximkrouk
Copy link
Copy Markdown
Contributor Author

@stephencelis, yep, it's ready :)

Copy link
Copy Markdown
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit 61c843c into pointfreeco:main Apr 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants