UIKit: Fix switch presented child double dismiss#332
Open
areschoug wants to merge 2 commits intopointfreeco:mainfrom
Open
UIKit: Fix switch presented child double dismiss#332areschoug wants to merge 2 commits intopointfreeco:mainfrom
areschoug wants to merge 2 commits intopointfreeco:mainfrom
Conversation
3 tasks
Contributor
|
I’m experiencing the same issue in my project, and this fix resolves it on my end as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes when changing the presented view controller from one to another, the parent also gets dismissed.
The fix is to check if the
presentedViewControlleris already being dismissed. If it is, wait for it to finish dismissing before presenting the new one. I'm piggybacking on_UIKitNavigation_onDismissto get a callback when the view controller is dismissed. Not sure if that is the best way to do it. We've used this in our project and it seems to work.