fix: Locale not passed to localized string resource#338
Open
Kaeldehta wants to merge 1 commit intopointfreeco:mainfrom
Open
fix: Locale not passed to localized string resource#338Kaeldehta wants to merge 1 commit intopointfreeco:mainfrom
Kaeldehta wants to merge 1 commit intopointfreeco:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the locale not being passed through to the LocalizedStringResource when initializing a String from TextState.
This change should align the behavior with the behavior for LocalizedStringKey
If there are issues with this implementation let me know. :)