Enable root view controller replacement in NavigationStackController#339
Open
lucamegh wants to merge 1 commit intopointfreeco:mainfrom
Open
Enable root view controller replacement in NavigationStackController#339lucamegh wants to merge 1 commit intopointfreeco:mainfrom
NavigationStackController#339lucamegh wants to merge 1 commit intopointfreeco:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses an issue that arises when using
NavigationStackControllerin combination withUISplitViewController.In my project, I configure the split view's columns at runtime by passing
NavigationStackControllerinstances to UISplitViewController.setViewController(_:for:). While this works as expected for primary/secondary/supplementary/inspector columns, it does not behave correctly for the compact column.On iOS 17 and earlier, the compact column is intended to be configured only once; subsequent attempts to replace it are ignored. As a result, dynamically updating the compact column by swapping out the entire navigation stack is not a viable approach.
If
NavigationStackControllerallowed updating its root view controller instead of requiring replacement of the entire stack, this limitation could be avoided.I understand that
NavigationStackControlleris modeled after SwiftUI’sNavigationStack. However,NavigationStackprovides greater flexibility by accepting aViewBuilderto construct its root content dynamically.