Restore Swift 6.1 support - #347
Merged
Merged
Conversation
A few things were broken.
stephencelis
commented
Aug 7, 2026
| named(allCasePaths), | ||
| named(_$Element) | ||
| ) | ||
| @attached(memberAttribute) |
Member
Author
There was a problem hiding this comment.
The #if CasePaths trait branching for macro attributes is syntax not supported in 6.1.
stephencelis
commented
Aug 7, 2026
| } | ||
| } | ||
|
|
||
| // NB: This overload is required due to an overload resolution bug of 'Updates[dynamicMember:]'. |
Member
Author
There was a problem hiding this comment.
Noticed this was fixed by the recent JSON changes, so dropping it.
stephencelis
commented
Aug 7, 2026
| public func nullif<Other: QueryExpression>( | ||
| _ other: Other | ||
| ) -> some QueryExpression<QueryValue._Optionalized> | ||
| ) -> SQLQueryExpression<QueryValue._Optionalized> |
Member
Author
There was a problem hiding this comment.
6.1 does not like this opaque result type.
stephencelis
commented
Aug 7, 2026
| } | ||
|
|
||
| @Test func `@Selection with empty struct`() { | ||
| @Test("@Selection with empty struct") func selectionWithEmptyStruct() { |
Member
Author
There was a problem hiding this comment.
6.1 cannot build these identifiers.
stephencelis
commented
Aug 7, 2026
| .package( | ||
| url: "https://github.com/pointfreeco/swift-dependencies", | ||
| from: "1.14.0", | ||
| traits: ["Foundation"] |
Member
Author
There was a problem hiding this comment.
6.1 can't scope traits this way without breaking dependents. If we want we could introduce another Package file for 6.2 or 6.3, wherever it's fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things were broken.