Skip to content

Run init_fido() at boot to fix USB hang on CTAPHID_INIT #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DmitriyLyalyuev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Run init_fido() at boot to fix USB hang on CTAPHID_INIT #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/fido/fido.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,16 @@ void init_fido(void) {
needs_power_cycle = false;
}

// Run heavy first-time init (key/cert generation, OTP counter increment, flash_commit)
// at boot — BEFORE USB enumeration starts. Otherwise the first CTAPHID_INIT triggers
// it from inside the set_report callback, and the resulting flash writes hang the USB
// pipe long enough that macOS times out and refuses further transfers until physical
// re-plug. See init_fido() above and pico-keys-sdk hid.c CTAPHID_INIT handler.
int picokey_init(void) {
init_fido();
return 0;
}

bool wait_button_pressed(void) {
uint32_t val = EV_PRESS_BUTTON;
#if defined(PICO_PLATFORM) || defined(ESP_PLATFORM)
Expand Down