Skip to content

Enforce alwaysUv on getAssertion #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaulttec-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enforce alwaysUv on getAssertion #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/fido/cbor_get_assertion.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,18 @@ int cbor_get_assertion(const uint8_t *data, size_t len, bool next) {
}
}

/* CTAP 2.1 6.2: with alwaysUv set, an assertion requires user verification.
makeCredential enforces this (cbor_make_credential.c), getAssertion upstream
does not - it only validates pinUvAuthParam when the platform bothers to send
one. With AUV advertised in getInfo that is a guarantee we would not keep:
registration would ask for the PIN and every subsequent login would not.
Same condition and same error as the makeCredential path. */
if (get_opts() & FIDO2_OPT_AUV) {
if (!file_has_data(ef_pin) || (pinUvAuthParam.present == false && options.uv != ptrue)) {
CBOR_ERROR(CTAP2_ERR_PUAT_REQUIRED);
}
}

if (pinUvAuthParam.present == true) { //6.1
int ret = verify((uint8_t)pinUvAuthProtocol, paut.data, clientDataHash.data, (uint16_t)clientDataHash.len, pinUvAuthParam.data);
if (ret != CborNoError) {
Expand Down