feat(places): add departments filtering#753
Open
ShahabFallah wants to merge 2 commits intomainfrom
Open
Conversation
github-actions
Bot
added
cc-feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for filtering places by department across the places feature. The main changes include updating hooks, navigation, and UI components to handle department-based filtering, as well as improvements to the
PillIconButtoncomponent. Below are the most important changes grouped by theme.UI Enhancements for Department Filter
PlacesScreen.tsxusingStatefulMenuViewand updated the filter button to display the selected department.PlacesScreen.tsxby adjusting layout and icon positioning for better accessibility and appearance.PillIconButton Component Improvements
PillIconButtoncomponent to support trailing icons via a newiconTrailingprop, enabling better UI flexibility for filter buttons. [1] [2] [3]