This repository was archived by the owner on Mar 11, 2026. It is now read-only.
Fix: Issue with bundler wasm not loading in the browser environment#60
Merged
Conversation
owonwo
commented
May 15, 2025
owonwo
commented
Contributor
- chore: lazy load wasm
- chore: disabled cjs bundle in favour of esm and fixed issue with webpack loading wasm
owonwo
changed the title
Member
|
Let's fix the commit history here; Use merge strategy when pulling changes from main instead of rebase. |
seunlanlege
reviewed
May 27, 2025
Member
There was a problem hiding this comment.
I think we should split this wasm module into its own package entirely
Member
There was a problem hiding this comment.
It imports correctly now, the wasm plugin for the vite test runner was missing initially.
Member
There was a problem hiding this comment.
Publishing it as a separate package means users might still have to set up plugins in some cases for the wasm to work correctly, whereas enforcing esm and node >= 23 means it would just work like every other package.
Wizdave97
approved these changes
May 27, 2025
owonwo
changed the title
Contributor
Author
|
@Wizdave97 I've skipped failing test cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.