Skip to content

[simplex]: shut down filler on delegation failure + raise set-code gas limit#950

Merged
Wizdave97 merged 5 commits into
mainfrom
roy/delegation-fail-fast-gas
Jun 5, 2026
Merged

[simplex]: shut down filler on delegation failure + raise set-code gas limit#950
Wizdave97 merged 5 commits into
mainfrom
roy/delegation-fail-fast-gas

Conversation

@royvardhan

@royvardhan royvardhan commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Addresses two issues raised by David on the filler's EIP-7702 delegation:

  • Fail fast. The filler now shuts down when delegation fails on all solver-selection chains. If only some chains fail, it logs a warning and continues on the chains that succeeded.
  • Gas limit error. Raised the flat set-code (0x04) gas limit from 350K → 650K, and fixed the Turnkey signer path which never applied the limit (it let viem estimate ~94k, which L2s reject).

@seunlanlege

Copy link
Copy Markdown
Member

does this shutdown when any chain delegation fails or when all fails?

@royvardhan

royvardhan commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

does this shutdown when any chain delegation fails or when all fails?

When any fail, so that on a restart, it skips the delegated ones and directly try failed ones.

@seunlanlege

Copy link
Copy Markdown
Member

does this shutdown when any chain delegation fails or when all fails?

When any fail, so that on a restart, it skips the delegated ones and directly try failed ones.

Should be when all fails

@royvardhan

Copy link
Copy Markdown
Collaborator Author

does this shutdown when any chain delegation fails or when all fails?

When any fail, so that on a restart, it skips the delegated ones and directly try failed ones.

Should be when all fails

Then if it continues to run, it will not be able to fill an order for the destination where it failed to delegate?

@seunlanlege

Copy link
Copy Markdown
Member

Then if it continues to run, it will not be able to fill an order for the destination where it failed to delegate?

That's fine

@Wizdave97 Wizdave97 merged commit 713a589 into main Jun 5, 2026
4 checks passed
@Wizdave97 Wizdave97 deleted the roy/delegation-fail-fast-gas branch June 5, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants