Skip to content

[evm]: cross-chain partial fills for IntentGatewayV2 #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seunlanlege wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[evm]: cross-chain partial fills for IntentGatewayV2 #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion evm/src/apps/IntentGatewayV2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,14 @@ contract IntentGatewayV2 is IntrinsicIntents, ExtrinsicIntents, ReentrancyGuardT
*/
function placeOrder(Order memory order, bytes32 graffiti) public payable nonReentrant {
if (order.inputs.length == 0) revert InvalidInput();
// Inputs and outputs pair 1:1 by index; reject mismatched orders that could never be filled.
if (order.inputs.length != order.output.assets.length) revert InvalidInput();

// Reject duplicate output tokens
// Reject duplicate output tokens
uint256 outputsLen_ = order.output.assets.length;
for (uint256 i; i < outputsLen_;) {
// A zero-amount output would strand its paired input escrow
if (order.output.assets[i].amount == 0) revert InvalidInput();
bytes32 token = order.output.assets[i].token;
assembly ("memory-safe") {
if tload(token) {
Expand Down
Loading