[evm,sdk]: fix reverting quote() on HyperApp and HyperFungibleToken#994
Merged
Conversation
Wizdave97
approved these changes
Jun 25, 2026
Wizdave97
left a comment
Wizdave97
left a comment
Member
There was a problem hiding this comment.
Bump the core package's patch version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HyperApp.quote()wasviewand calledgetAmountsInthrough an interface that declared itpure, so the compiler emitted aSTATICCALL. On mainnet the host's fee oracle is now a Uniswap V3 quoter wrapper whosegetAmountsInprices by executing a swap and reverting to read the result — a state write that aSTATICCALLrejects, soquote()reverts.Dropped
view/pureso the call runs as aCALL, and propagated the change to theHyperFungibleToken/WrappedHyperFungibleTokenquoteoverrides. The SDK now readsquoteviasimulateContract(eth_call) since it is no longer a view function. Added a mainnet-fork test that prices a send through the realUniV3UniswapV2Wrapper.Ships as an implementation upgrade behind the existing WHFT proxy; no proxy/state redeployment.
Closes #987