Restore the pony-ffi-audit skill - #49
Open
SeanTAllen wants to merge 1 commit into
Open
Conversation
Brings back the FFI safety audit skill removed in the past because it wasn't ready for use (#27). Restored from history and brought up to the repo's current conventions: prose reflowed to flow rather than hard-wrap, the addressof escape-hatch description corrected to note it applies to `var` targets, an up-front scope note added, and the example audit's summary arithmetic reconciled (the three violation patterns total 42; runtime event handles are intentional and counted separately). Deliberately does not reference the unmerged ponyc unsafe-pointer work — the audit's mutation-capability methodology is orthogonal to that split and remains correct against released ponyc. Closes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pony-ffi-auditskill is available again. It's an audit methodology for finding FFI calls where C mutates Pony data through a non-mutable reference capability (val,box, ortag) — the kind of violation the compiler trusts the FFI declaration about and won't catch. The skill walks through finding every FFI call site, determining what the C function actually writes, and checking whether the Pony refcap permits it, with a worked example showing the reporting format.It was removed earlier because it wasn't ready for use (#27). This restores it, brought up to the repo's current documentation conventions.
Closes #27