Use phantom primitive for TLS_method return type - #144
Merged
Conversation
TLS_method returns const SSL_METHOD *, an opaque struct pointer. Pointer[None] is for void * or always-null; this is neither. Closes #131
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLS_methodreturnsconst SSL_METHOD *, an opaque struct pointer. The FFI declaration usedPointer[None]— the convention forvoid *or always-null pointers — instead of a phantom primitive. Every other opaque-struct return in the tree (EVP_sha256,BIO_s_mem,EVP_MD_CTX_new) already gets this right.Adds
_SSLMethodand uses it in both the@TLS_methodreturn type and the@SSL_CTX_newparameter.Closes #131